ssthouse commented on pull request #15095: URL: https://github.com/apache/echarts/pull/15095#issuecomment-856483466
> It seems this will break the case in which all the number is negative. Besides, if the negative value was considered as `0`, how does the tooltip show? Should it be `0`(as the pie shows) or the original negative value like `-1548`? @plainheart hi, In my previous edition(see the first two commits of this PR). the negative value is considered as `0` when calculating pie slices. And the tooltip shows the negative value label; like below:  --- according to @Ovilia and @pissang's suggestion, I moved the filter logic to `processor/negativeDataFilter`( see the 3rd commit of this PR). and in this edition, the negative value will only be shown in legend and not in pie slices. like below:  I'm not sure which result is expected since they're both reasonable in some way，hope you guys can give me a conclusion😂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
