Ovilia commented on a change in pull request #16026:
URL: https://github.com/apache/echarts/pull/16026#discussion_r813530332
##########
File path: src/component/marker/MarkLineView.ts
##########
@@ -192,7 +193,7 @@ function markLineFilter(
}
}
return markerHelper.dataFilter(coordSys, item[0])
- && markerHelper.dataFilter(coordSys, item[1]);
+ || markerHelper.dataFilter(coordSys, item[1]);
Review comment:
Do we need to consider polar system here?
##########
File path: src/component/marker/MarkLineView.ts
##########
@@ -190,9 +192,22 @@ function markLineFilter(
) {
return true;
}
+ const lineStart = coordSys.dataToPoint(item[0].coord);
+ const lineEnd = coordSys.dataToPoint(item[1].coord);
+ const area = (coordSys as Cartesian2D).getArea();
+ const isIntersect = linePolygonIntersect(
+ lineStart[0], lineStart[1], lineEnd[0], lineEnd[1],
+ [
+ [area.x, area.y], [area.width + area.x, area.y],
+ [area.x, area.height + area.y], [area.width + area.x,
area.height + area.y]
Review comment:
This seems to be shaped as "Z". Should the `[area.width + area.x,
area.height + area.y]` be before `[area.x, area.height + area.y]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
