[GitHub] [echarts] plainheart opened a new pull request, #16971: fix(markLine): fix markLine label shows wrong tooltip content

Mon, 02 May 2022 13:42:45 -0700 


plainheart opened a new pull request, #16971:
URL: https://github.com/apache/echarts/pull/16971

   <!-- Please fill in the following information to help us review your PR more 
efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Fix #16911 - the markLine label shows wrong tooltip content.
   
   ### Fixed issues
   
   #16911
   
   ## Details
   
   ### Before: What was the problem?
   
   The tooltip shows wrong content when hovering on the markLine label as its 
host target is missing the `dataModel`.
   
   <img 
src="https://user-images.githubusercontent.com/26999792/166323585-da116371-010b-4f8f-b46b-02583abf4892.png";
 width="200">
   
   
   ### After: How is it fixed in this PR?
   
   Also set `dataModel` for the `markLine` self.
   
   <img 
src="https://user-images.githubusercontent.com/26999792/166323415-23b10575-580c-4eda-b346-1e7230ec8b54.png";
 width="200">
   
   ## Misc
   
   <!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
   
   - [ ] The API has been changed (apache/echarts-doc#xxx).
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   Please refer to the second case in `test/marker-case.html`
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to