pissang commented on code in PR #16972:
URL: https://github.com/apache/echarts/pull/16972#discussion_r863491467


##########
src/component/visualMap/PiecewiseView.ts:
##########
@@ -215,10 +215,13 @@ class PiecewiseVisualMapView extends VisualMapView {
     ) {
         const visualMapModel = this.visualMapModel;
         const option = visualMapModel.option;
+        if (!option.selectedMode) {

Review Comment:
   LGTM. A small suggestion on the style: `option.selectedMode` can be assigned 
to a temporal variable to get a smaller code size.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to