[GitHub] [echarts] Ovilia commented on pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Thu, 26 May 2022 01:49:42 -0700 


Ovilia commented on PR #16947:
URL: https://github.com/apache/echarts/pull/16947#issuecomment-1138310813

   I have some concern on this PR.
   
   I think it may be a better idea to hide min/max line only if the first/last 
tick is not calculated by *nice tick* (which usually happens when the user 
deliberately sets a min/max value to the axis.
   
   For example, in [this 
demo](https://echarts.apache.org/examples/zh/editor.html?c=line-function&code=GYVwdgxgLglg9mABKSAKAHgSkQbwFCKLqID0AvIgIwAMA3AYgE4CmUIjSAsgIZQAWAOgDOMMBmwAqRD34CIcIRkRSATIgDUVSdN6CRY4lIDMGxCu0BWOngC-eFNHhIA5szDNGvZgBFe3VNj4hAA2rIgAJn6IFADaALr0hMBwjIiooVCIMNGIALQqdFmIADwUBbRF6hTUApSBDISRUNwCAA4gQnyoMTAANMjgEKgwmHGYiYh2hCxsHBF-9HZwrbAIOUGI3GAwALa8TgBcyNzBQsy9DM6MMOFHG4RQy0cALNQXhCHMwFBHVu8f12cfB-iFe_0IACM4FBHjtftQGDZ_ugAILoGBCO4NRBgbg7ZhHADk6EJ4NIJEQO1ER3yb2xQlawRgUAAMqICbhsR9EJ04AB3I5QRggc5cj5M9wAZSgAE9QljuYrEPJgikiSxwoSxYQph9dUiGDK0RiFR9cfiiTKtTr_mdrsxMYgYtj7h9Za0OYSJcxSWLeXzJTKdlDgkdgCczmTCBAma1BcLRUqmtwjq53J4oD4_AFsbq4rZaEA),
 the min tick is `-20` and it is expected to be displayed because `-20` is a 
*nice tick*.
   
   <img width="811" alt="image" 
src="https://user-images.githubusercontent.com/779050/170453541-3e285f15-ea17-41a6-ae2c-f94d5101ff94.png";>
   
   
   While in [another 
case](https://echarts.apache.org/examples/zh/editor.html?c=line-function&code=GYVwdgxgLglg9mABKSAKAHgSkQbwFCKLqID0AvIgIwAMA3AYgE4CmUIjSAsgIZQAWAOgDOMMBmwAqRD34CIcIRkRSATIgDUVSdN6CRY4lIDMGxCu0BWOngC-eFNHhIA5szDNGvZgBFe3VNj4hAA2rIgAJn6IFADaALr0hMBwjIiooVCIMNGIALQqdFmIADwUBbRF6hTUApSBDISRUNwCAA4gQnyoMTAANMjgEKgwmHGYiYh2hCxsHBF-9HZwrbAIOUGI3GAwALa8TgBcyNzBQsy9DM6MMOFHG4RQy0cALNQXhCHMwFBHVu8f12cfB-iFe_0IACM4FBHjtftQGDZ_ugAILoGBCO4NRBgbg7ZhHADk6EJ4MQO1ER3yKjJQlawRgUAAMqICbhsR9EJ04AB3I5QRggc4cj4M9wAZSgAE9QljOfLEPJgikiSxwoSRYQph9tUiGFK0Ri5R9cfiiVKNVr_mdrsxMYgYtj7h9pa02YSxcxSSLuTzxVKdlDgkdgCczmTCBAGa1-YLhQqmtwjq53J4oD4_AFsdq4rZaEA),
 the axis is set to have `min: -22`. In this case, the splitLine of `-22` is 
expected to be hidden if `showMinLine` is set to be `false`.
   
   <img width="807" alt="image" 
src="https://user-images.githubusercontent.com/779050/170453484-0cfa48a0-c702-4284-86d6-68920d296013.png";>
   
   
   I think this logic may make more sense. @pissang What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to