jiawulin001 opened a new pull request, #17217: URL: https://github.com/apache/echarts/pull/17217
<!-- Please fill in the following information to help us review your PR more efficiently. --> ## Brief Information This pull request is in the type of: - [x] bug fixing - [ ] new feature - [ ] others ### What does this PR do? <!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. --> Fix the error that occurs when declaring area with x/y in `markArea` ### Fixed issues - #5832 - #7055 - #10074 ## Details ### Before: What was the problem? As is described in issues, when setting x and y to denote an area for `markArea`, the error occurs. This is caused becasue `lt` and `rb` returned by `dataTransform()` has no attribute `coord` when user does not specify `coord` in `markArea.data`. So when running the following code, Echarts reads `lt.coord` and throw an error. https://github.com/apache/echarts/blob/11a9247e7fab2e6ff9c60b545ba775e8c1b2412f/src/component/marker/MarkAreaView.ts#L69-L79  ### After: How does it behave after the fixing? Now before `dataTransform()` return an `item`, a check is added and make sure there's a `coord` attribute in it (even `coord` is not needed). And there will be no errors caused by this. ## Document Info One of the following should be checked. - [x] This PR doesn't relate to document changes - [ ] The document should be updated later - [ ] The document changes have been made in apache/echarts-doc#xxx ## Misc ### ZRender Changes - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx). ### Related test cases or examples to use the new APIs N.A. ## Others ### Merging options - [x] Please squash the commits into a single one when merging. ### Other information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
