Ovilia commented on code in PR #17322: URL: https://github.com/apache/echarts/pull/17322#discussion_r914418485
########## src/scale/Log.ts: ########## @@ -86,8 +86,9 @@ class LogScale extends Scale { setExtent(start: number, end: number): void { const base = this.base; - start = mathLog(start) / mathLog(base); - end = mathLog(end) / mathLog(base); + // log(-Infinity) is NaN, so safe guard here + start = mathLog(Math.max(0, start)) / mathLog(base); + end = mathLog(Math.max(0, end)) / mathLog(base); Review Comment: If cache is required, maybe it's better to be implemented inside `mathLog`. But first of all, do we need to cache this? Is there any performance problem issued? If not, making a cache takes more space and may not be worthy the price. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org