[GitHub] [echarts] MeetzhDing opened a new pull request, #18078: fix(axis): containLabel work with multi axis without offset. fix #18077

Mon, 19 Dec 2022 03:24:22 -0800 


MeetzhDing opened a new pull request, #18078:
URL: https://github.com/apache/echarts/pull/18078

   <!-- Please fill in the following information to help us review your PR more 
efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   fix #18077 .
   
   grid.containLabel will work better when multi axis.
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   If you don‘t provide yAxis.offset, labels will overlay.
    But every yAxis will take extra space in grid when grid.containLabel is 
true.
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   <img width="808" alt="image" 
src="https://user-images.githubusercontent.com/12808432/208414830-1a9c8316-a6d9-403c-b2d2-3b359d5a9a2b.png";>
   
   
   
   ### After: How does it behave after the fixing?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. 
-->
   
   In `grid.containLabel` logic, if axis.offset is not provided, it will calc 
by `labelUnionRect`.
   
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   <img width="894" alt="image" 
src="https://user-images.githubusercontent.com/12808432/208415356-65e116fc-6e5e-4b17-b436-6ffa41bfef0e.png";>
   
   
   
   ## Document Info
   
   One of the following should be checked.
   
   - [x] This PR doesn't relate to document changes
   - [ ] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to