plainheart commented on code in PR #18301: URL: https://github.com/apache/echarts/pull/18301#discussion_r1115506865
########## .npmignore: ########## @@ -10,5 +10,6 @@ .DS_Store Thumbs.db Desktop.ini +/asset/contributing-inspect.png Review Comment: We can ignore the whole `asset` folder and the `CONTRIBUTING.md` seems also unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![[GitHub] [echarts] plainheart commented on a diff in pull request #18301: Ignore file '\asset\contributing-inspect.png' when publish to npm](/search?l=commits@echarts.apache.org&q=subject:%22%5C%5BGitHub%5C%5D+%5C%5Becharts%5C%5D+plainheart+commented+on+a+diff+in+pull+request+%2318301%5C%3A+Ignore+file+%27%5C%5Casset%5C%5Ccontributing%5C-inspect.png%27+when+publish+to+npm%22&o=newest){kind=link}
