linghaoSu opened a new pull request, #18491: URL: https://github.com/apache/echarts/pull/18491
<!-- Please fill in the following information to help us review your PR more efficiently. --> ## Brief Information This pull request is in the type of: - [x] bug fixing - [ ] new feature - [ ] others ### What does this PR do? 1. For `polyline`, with animation on, to filter out nodes that are about to exit, and clear `sourceEdge` if the number of remaining nodes is 0 2. For all `tree`, with animation off, pass the current node in `removeNodeEdge` since the current node is immediately deleted, making it impossible to get the current node by dataIndex. <!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. --> ### Fixed issues <!-- - #xxxx: ... --> - #18448 - #18490 ## Details ### Before: What was the problem? 1. For `polyline`, when a child node is removed by updating the node, the line is not removed 2. For all `trees`, when collapsing a node with animation off, lines will be left behind <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. --> <!-- ADD SCREENSHOT HERE IF APPLICABLE. --> ### After: How does it behave after the fixing? 1. for `polyline`, when a child node is removed by updating the node, the lines will be removed 2. For all `trees`, collapse the node with the animation off, no lines will be left <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. --> <!-- ADD SCREENSHOT HERE IF APPLICABLE. --> ## Document Info One of the following should be checked. - [x] This PR doesn't relate to document changes - [ ] The document should be updated later - [ ] The document changes have been made in apache/echarts-doc#xxx ## Misc ### ZRender Changes - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx). ### Related test cases or examples to use the new APIs N.A. ## Others ### Merging options - [ ] Please squash the commits into a single one when merging. ### Other information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
