Ovilia commented on code in PR #19435:
URL: https://github.com/apache/echarts/pull/19435#discussion_r1452067343
##########
src/chart/pie/PieSeries.ts:
##########
@@ -299,6 +318,11 @@ class PieSeriesModel extends SeriesModel<PieSeriesOption> {
opacity: 1
},
+ showBackground: false,
+ backgroundStyle: {
+ opacity: 1
Review Comment:
Setting `opacity: 1` by default is confusing and unconvenient. How about
make it 0.25 by default?
##########
src/chart/pie/PieView.ts:
##########
@@ -268,12 +272,43 @@ class PieView extends ChartView {
group.add(sector);
}
+
+ const animationModel = seriesModel.isAnimationEnabled() ? seriesModel
: null;
+ const drawBackground = seriesModel.get('showBackground', true);
+ const basicOuterRadius = getBasicPieLayout(seriesModel, api).r;
+ const bgStyle = seriesModel.getModel('backgroundStyle').getItemStyle();
Review Comment:
If `data.backgroundStyle` is not supported, how should developers set each
pie piece to be a different color other than the default colors? I would
suggest supporting `data.backgroundStyle` but not `data.showBackground` (only
`series.showBackground` is supported).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
