alxnddr commented on PR #19602: URL: https://github.com/apache/echarts/pull/19602#issuecomment-1941795702
@helgasoft thanks for your feedback. In my pull request I addressed areas stacking when `connectNulls` is enabled so that it literally connects polygon lines on null values instead of dropping the area polygon to zero which does not look correct: <img width="1442" alt="Screenshot 2024-02-08 at 4 29 21 PM" src="https://github.com/apache/echarts/assets/14301985/1cd0ce0f-7cf3-4cd2-a147-2844130e49bf";> Manually interpolating values would break the `step` property behavior, and in addition to it supporting `smooth` would be a disproportionate effort to implement with custom interpolation. To summarize - the existing behavior is not correct which was was reported by a few people - the PR changes make `connectNulls` work as it is called — connect line and polygon on null values - there is no workaround that does not limit users from using other features of ECharts Based on these points, I believe this change is valid to be merged to the library code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
