andreasgerstmayr commented on code in PR #16547:
URL: https://github.com/apache/echarts/pull/16547#discussion_r1501141500
##########
src/scale/Log.ts:
##########
@@ -36,9 +36,28 @@ const roundingErrorFix = numberUtil.round;
const mathFloor = Math.floor;
const mathCeil = Math.ceil;
const mathPow = Math.pow;
-
const mathLog = Math.log;
+/**
+ * symmetric log, allowing negative values for logarithmic scales
+ */
+function symMathLog(x: number): number {
+ if (x >= 0) {
+ return mathLog(x);
+ }
+ return -mathLog(-x);
+}
+
+/**
+ * symmetric pow, allowing negative values for logarithmic scales
+ */
+function symMathPow(x: number, y: number): number {
+ if (y >= 0) {
Review Comment:
Good idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
