plainheart commented on code in PR #19373:
URL: https://github.com/apache/echarts/pull/19373#discussion_r1502089360


##########
test/dataset-layout.html:
##########
@@ -204,22 +204,26 @@
                     height: 500
                 });
 
+                var curDimension = 0;
                 chart && chart.on('updateAxisPointer', function (event) {
                     var xAxisInfo = event.axesInfo[0];
                     if (xAxisInfo) {
                         var dimension = xAxisInfo.value + 1;
-                        chart.setOption({
-                            series: {
-                                id: 'pie',
-                                label: {
-                                    formatter: '{b}: {@[' + dimension + ']} 
({d}%)'
-                                },
-                                encode: {
-                                    value: dimension,
-                                    tooltip: dimension
+                        if(curDimension === dimension){

Review Comment:
   1. Should use `!==`.
   2. Insert a space before `(` and after `)` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

Reply via email to