Ovilia opened a new pull request, #20184: URL: https://github.com/apache/echarts/pull/20184
<!-- Please fill in the following information to help us review your PR more efficiently. --> ## Brief Information This pull request is in the type of: - [x] bug fixing - [ ] new feature - [ ] others ### What does this PR do? <!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. --> When angleAxis in the polar system has `boundaryGap: false`, the extent is adjusted since [this commit](https://github.com/apache/echarts/commit/2fcdde6ea773514ff34e2eceece1c97bfe2ebb47#diff-43424e7431043adf45e3aba374fe74528fe1475b0e098246b6e4454578fc1aa5R127-R130) so that polar bars don't overlap each other. The main idea is to make extra space according to data count. But it may overkill in some situations. ### Fixed issues NA. This PR is not a fix to #20172 , which is not a bug. ## Details ### Before: What was the problem? Consider the case when `startAngle: 90, endAngle: -90`, before this PR, it has the result of: <img width="468" alt="image" src="https://github.com/user-attachments/assets/114eb20d-d205-47f6-9923-ce8d34c19516";> This is not as expected because a developer set `startAngle: 90, endAngle: -90` would expect the range to be half a circle. ### After: How does it behave after the fixing? The extent of angleAxis with `boundaryGap: false` should only be adjusted if it has the potential to overlap, that is to say, `startAngle: 90, endAngle: -90` should still get half a circle: <img width="502" alt="image" src="https://github.com/user-attachments/assets/208e9194-7c2a-4c4c-8df7-bd54a05a67bf";> while `startAngle: 90, endAngle: -270` should get 3/4 of a circle: <img width="561" alt="image" src="https://github.com/user-attachments/assets/afd918b4-da27-464c-9682-5467302a2ba4";> Please also not that if the range of startAngle and endAngle itself is over 360 degrees, it won't adjust to be smaller than a circle because it is not expected to. <img width="691" alt="image" src="https://github.com/user-attachments/assets/b960c4b0-0e30-48bd-a65f-6092839a1713";> ## Document Info One of the following should be checked. - [x] This PR doesn't relate to document changes - [ ] The document should be updated later - [ ] The document changes have been made in apache/echarts-doc#xxx ## Misc ### ZRender Changes - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx). ### Related test cases or examples to use the new APIs N.A. ## Others ### Merging options - [ ] Please squash the commits into a single one when merging. ### Other information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
