100pah commented on code in PR #20226:
URL: https://github.com/apache/echarts/pull/20226#discussion_r1703897967
##########
src/model/Global.ts:
##########
@@ -161,6 +162,8 @@ class GlobalModel extends Model<ECUnitOption> {
private _optionManager: OptionManager;
+ private _customSeriesManager: CustomSeriesManager;
Review Comment:
I think the member `_customSeriesManager` not necessary.
Moreover, `class CustomSeriesManger` is not necessary. Typically, a class
may suggests that it can be instantiated but the method "register" and "get"
are all static and should not be instantiated.
So it would be more appropriate to refactor `CustomSeriesManager.ts` to only
include the static functions "register" and "get", without a class wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
