100pah commented on code in PR #20082:
URL: https://github.com/apache/echarts/pull/20082#discussion_r1829482819
##########
src/component/dataZoom/SliderZoomModel.ts:
##########
@@ -79,6 +79,8 @@ export interface SliderDataZoomOption extends DataZoomOption,
BoxLayoutOptionMix
handleIcon?: string
+ handleLabelShow?: boolean
Review Comment:
+1. Both `show` and `handle` and be a verb or an noun. `handleLabelShow`
could be understand as handle the show of a label. Is `showHandleLabel` more
natural?
##########
src/component/dataZoom/SliderZoomModel.ts:
##########
@@ -79,6 +79,8 @@ export interface SliderDataZoomOption extends DataZoomOption,
BoxLayoutOptionMix
handleIcon?: string
+ handleLabelShow?: boolean
Review Comment:
+1. Both `show` and `handle` and be a verb or a noun. `handleLabelShow`
could be understand as handle the show of a label. Is `showHandleLabel` more
natural?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
