Ovilia commented on code in PR #18164:
URL: https://github.com/apache/echarts/pull/18164#discussion_r1830534724
##########
src/component/legend/legendAction.ts:
##########
@@ -37,6 +37,9 @@ function legendSelectActionHandler(methodName, payload,
ecModel) {
else if (methodName === 'allSelect' || methodName === 'inverseSelect')
{
legendModel[methodName]();
}
+ else if (methodName === 'legendMouseover' || methodName ===
'legendMouseout') {
+ isSelected = legendModel.isSelected(payload.name);
Review Comment:
This is perhaps no longer needed. You make merge the current master code and
have a double check.
##########
src/component/legend/legendAction.ts:
##########
@@ -37,6 +37,9 @@ function legendSelectActionHandler(methodName, payload,
ecModel) {
else if (methodName === 'allSelect' || methodName === 'inverseSelect')
{
legendModel[methodName]();
}
+ else if (methodName === 'legendMouseover' || methodName ===
'legendMouseout') {
+ isSelected = legendModel.isSelected(payload.name);
Review Comment:
You should update the `LegendSelectMethodNames` after merging from master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
