100pah commented on code in PR #20166:
URL: https://github.com/apache/echarts/pull/20166#discussion_r1835340984
##########
src/component/marker/markerHelper.ts:
##########
@@ -146,6 +146,7 @@ export function dataTransform(
// x y is provided
if (item.coord == null || !isArray(dims)) {
item.coord = [];
+ item.value = numCalculate(data, data.mapDimension(dims[1]), item.type);
Review Comment:
Should it be
```js
numCalculate(data, data.mapDimension(seriesModel.getBaseAxis()), item.type);
```
?
##########
src/coord/polar/Polar.ts:
##########
@@ -234,7 +234,13 @@ class Polar implements CoordinateSystem,
CoordinateSystemMaster {
const r0 = this.r0;
return d2 <= r * r && d2 >= r0 * r0;
- }
+ },
+
+ // As the bounding box
+ x: this.cx - radiusExtent[1],
+ y: this.cy - radiusExtent[1],
+ width: radiusExtent[1] * 2,
+ height: radiusExtent[1] * 2
Review Comment:
Should we support `r0 > r1`? I tried it just now and it works.
It might be more robustness if take the `max(radiusExtent[0],
radiusExtent[1])` here.
##########
src/component/marker/MarkerModel.ts:
##########
@@ -53,6 +53,7 @@ export interface MarkerPositionOption {
// Absolute position, px or percent string
x?: number | string
y?: number | string
+ relativeTo?: 'screen' | 'coordinate'
Review Comment:
1. I think that using `screen` might misleads users, because the the chart
is just a part of a html webpage, and in CSS the `screen` already has some
specific meaning (also doesn't refer to the real screen but the semantic is
well-known).
But I haven't come up with a perfect name yet.
Some candidates:
- `viewport` (also has specific meaning in HTML/CSS but better than screen?)
- `global` (a more general term?)
- `global-container`
2. The term `coordinate` is a point in a coordinate system, rather than
coordinate system itself.
Should this option be `coordinateSystem` or `coordinate-system`, since the
term `coordinateSystem` has been used in echarts option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
