100pah commented on code in PR #19941:
URL: https://github.com/apache/echarts/pull/19941#discussion_r1840451367


##########
src/coord/axisCommonTypes.ts:
##########
@@ -81,6 +81,9 @@ export interface AxisBaseOptionCommon extends ComponentOption,
      */
     max?: ScaleDataValue | 'dataMax' | ((extent: {min: number, max: number}) 
=> ScaleDataValue);
 
+    jitter?: number;

Review Comment:
   + (readability issue): The meaning of this option `jitter` can't be presumed 
by the naming and no comment here.
   
   + I think we should better to support automatic calculation of the jitter 
boundary (radius) based on tick span of the axis? Otherwise, if the chart is 
resizable, or if their are multiple values of the category axis, users may be 
not able to find an appropriate pixel value of boundary radius. If using a 
wrong jitter value, some of the outcome coords might be inappropriate (e.g. a 
negative value or out of the cartesian and not drawn). If auto calculation is 
supported, users can simply configured it as 
       + `xAxis: { jitter: true }` to get a perfect result, where jitter radius 
is auto calculated by tick span.
       + `xAxis: { jitter: { radius: 400, overlap: false }}` to set as 400px.
       + `xAxis: { jitter: { radius: '80%', overlap: false }}` to get 80% of 
the tick span.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to