Ovilia opened a new pull request, #20557: URL: https://github.com/apache/echarts/pull/20557
<!-- Please fill in the following information to help us review your PR more efficiently. --> ## Brief Information This pull request is in the type of: - [x] bug fixing - [ ] new feature - [ ] others ### What does this PR do? <!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. --> When checking if the symbol should be flipped with zero value, it's different situations to consder when axis is horizontal/vertical and whether is inversed. #20300 tried to fix one situation but didn't consider others so it brought bug with `test/pictorial-zero-value-offset.html`. This PR fix this problem and provided test cases with the combination of horizontal/vertical axis and whether or not inversed. ### Fixed issues <!-- - #xxxx: ... --> ## Details ### Before: What was the problem? <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. --> <!-- ADD SCREENSHOT HERE IF APPLICABLE. --> `test/pictorial-zero-value-offset.html` has a wrong flipped symbol. ### After: How does it behave after the fixing? <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. --> <!-- ADD SCREENSHOT HERE IF APPLICABLE. --> `test/pictorial-zero-value-offset.html` has no diff with 5.5.1 and fix all possible situations with the axis. ## Document Info One of the following should be checked. - [x] This PR doesn't relate to document changes - [ ] The document should be updated later - [ ] The document changes have been made in apache/echarts-doc#xxx ## Misc ### ZRender Changes - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx). ### Related test cases or examples to use the new APIs N.A. ## Others ### Merging options - [ ] Please squash the commits into a single one when merging. ### Other information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
