Ovilia commented on code in PR #20677:
URL: https://github.com/apache/echarts/pull/20677#discussion_r1912777738
##########
src/core/echarts.ts:
##########
@@ -1131,6 +1132,7 @@ class ECharts extends Eventful<ECEventDefinition> {
params.event = e;
params.type = eveName;
+ params.dimensionIndex = dispatcher ? dispatcher.__dimIdx :
undefined;
Review Comment:
If `__dimIdx` is only for radar series, then it's not a good idea to bind it
in `core/echarts.ts` because it breaks the encapsulation. Find other ways to
bypass the information with `eventData` may be a better idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
