100pah commented on PR #19534: URL: https://github.com/apache/echarts/pull/19534#issuecomment-2742361420
When perform visual test in v6, I found substantial breaking changes introduced by this feature. I thinks the breaking change is unnecessary for some users, since the axis name might be used as as "title" and the layout has been nicely adjusted. If we impose this breaking change, it forces them to either modify the code or give up on upgrading to v6 and latter versions. I still believe the compatibility should be the top priority, as modifying legacy code often come with considerable cost but offers few benefits. So could we introduce this feature without breaking changes? For example, A. introduce a new option values on `grid.containLabel: false | true | 'all'`, meaning that contain label and title, while keep the previous `containLabel: true` be only contain label. B. introduce a new option like `grid.layoutContain: 'label' | 'all'` to convey this meaning, and `containLabel: true` equals to `layoutContain: 'label'` C. other better naming? @Ovilia What's you opinion? (If it can be accepted, I can modify it.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
