Justin-ZS commented on PR #20838:
URL: https://github.com/apache/echarts/pull/20838#issuecomment-2804121177

   > I’ve experienced this problem as a user so interested to see how this PR 
progresses, I will say the naming here is a bit confusing, especially since 
ECharts already supports a different concept as: `min: 'dataMin'` and `max: 
‘dataMax’`
   
   I intentionally use the terms `dataMin/dataMax`:
   1. From a usage perspective, `dataMin/dataMax` should not be used 
simultaneously with `min/max`.
   2. If a user does combine them, `dataMin/dataMax` will affect the result of 
`min: 'dataMin'` and `max: ‘dataMax’`.
   For example: if the original data range is `[100, 300]`, setting `{ dataMax: 
500, max: 'dataMax' }` will fix the axis maximum to 500.
   Using the same terms here makes the it more intuitive.
   3. I'm open to change the name if the maintainers have any recommendations


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to