plainheart commented on code in PR #20969:
URL: https://github.com/apache/echarts/pull/20969#discussion_r2151099583


##########
src/component/toolbox/feature/DataView.ts:
##########
@@ -375,7 +377,8 @@ class DataView extends 
ToolboxFeature<ToolboxDataViewFeatureOption> {
         const blockMetaList = result.meta;
 
         const buttonContainer = document.createElement('div');
-        buttonContainer.style.cssText = 
'position:absolute;bottom:5px;left:0;right:0';
+        const buttonExtraCssText = model.get('buttonExtraCssText') || '';
+        buttonContainer.style.cssText = 'position:absolute;' + 
buttonExtraCssText;

Review Comment:
   `buttonExtraCssText` looks like it is for a single button rather than the 
button container, and can be misleading.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to