StNimmerlein commented on code in PR #21224:
URL: https://github.com/apache/echarts/pull/21224#discussion_r2315441968
##########
src/chart/gauge/GaugeView.ts:
##########
@@ -564,6 +564,11 @@ class GaugeView extends ChartView {
const progress = progressList[idx];
progress.useStyle(data.getItemVisual(idx, 'style'));
progress.setStyle(itemModel.getModel(['progress',
'itemStyle']).getItemStyle());
+ if (progress.style.fill === 'auto') {
+ progress.setStyle('fill', getColor(
Review Comment:
I extracted the variable, but without the ternary (so it could be used in
other cases as well).
If you prefer the ternary to be there for performance purposes, I can add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
