100pah commented on code in PR #20838:
URL: https://github.com/apache/echarts/pull/20838#discussion_r2384917982
##########
src/coord/scaleRawExtentInfo.ts:
##########
@@ -98,6 +103,19 @@ export class ScaleRawExtentInfo {
const isOrdinal = this._isOrdinal = scale.type === 'ordinal';
this._needCrossZero = scale.type === 'interval' &&
model.getNeedCrossZero && model.getNeedCrossZero();
+ if (scale.type === 'interval' || scale.type === 'log') {
+ // Process custom dataMin/dataMax
+ this._dataMinRaw = (model as
AxisBaseModel<NumericAxisBaseOptionCommon>).get('dataMin', true);
Review Comment:
`_dataMinRaw` and `_dataMaxRaw` is never used outside this function and do
not need to persist. Therefore, it should be a local variable rather that a
class member.
##########
src/coord/scaleRawExtentInfo.ts:
##########
@@ -98,6 +103,19 @@ export class ScaleRawExtentInfo {
const isOrdinal = this._isOrdinal = scale.type === 'ordinal';
this._needCrossZero = scale.type === 'interval' &&
model.getNeedCrossZero && model.getNeedCrossZero();
+ if (scale.type === 'interval' || scale.type === 'log') {
Review Comment:
I think `scale.type === 'time'` can be added to this condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
