akashsonune commented on PR #21306:
URL: https://github.com/apache/echarts/pull/21306#issuecomment-3388851557

   > Based on the test case you provided, if you print out `console.log(angle, 
layout.r0, layout.r0 === 0, angle === 2 * Math.PI);`, you should see 
`SunburstPiece.ts:236 6.283185307179587 0 true false`, which means the problem 
is caused by the precision of _Math.PI * 2_. So this can be simply fixed as
   > 
   > ```
   > if (layout.r0 === 0 && isRadianAroundZero(angle - 2 * Math.PI))
   > ```
   > 
   > And please don't use _forced pushes_ because we need to reserve the commit 
history. Thanks!
   
   @Ovilia Thank you for the feedback. I guess it works perfectly. can you take 
a look now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to