Justin-ZS commented on PR #21378: URL: https://github.com/apache/echarts/pull/21378#issuecomment-3601202878
> Thanks for your contribution. > > Would it be better to implement this as a new custom series in [echarts-custom-series](https://github.com/apache/echarts-custom-series) and only add `splitLine.shape` in this PR? Using a line series to simulate a radar chart seems like a workaround. Also, since the line series is a commonly used chart type, we should be cautious about both the additional logic and the impact on bundle size. > > <img alt="Image" width="332" height="521" src="https://private-user-images.githubusercontent.com/779050/520013052-2c3adc0d-d8ea-49b2-8627-0c86347defea.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjQ2NjgzODcsIm5iZiI6MTc2NDY2ODA4NywicGF0aCI6Ii83NzkwNTAvNTIwMDEzMDUyLTJjM2FkYzBkLWQ4ZWEtNDliMi04NjI3LTBjODYzNDdkZWZlYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUxMjAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MTIwMlQwOTM0NDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05Y2Q2MzNiMjk2ZjY0MjAwNDM1NmIxMWMwY2ZmOWVhNzg5OGRjZTYzZmEyZDVmMmJhOTc3ODVmNzRhYzZiODg0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.GjmpE-2Qh4jTp0A1_6o2QJJ2kKhgQR7AbUfsqhwnwI4";> > It looks like you may need to remove `shape: 'polygon'` in the test case above and test the default value. Re: custom series — The goal here is to extend and reuse polar line capabilities，not as a workaround. For `single-metric + single-dimension` (a common use case), the radar chart doesn't work well. Re: line series changes — Agreed on being cautious. That's why only two options are added (`connectEnds` + `splitLine.shape`), both strictly scoped to polar coordinate system. Re: bundle size — The actual delta is ~150 lines across 5 files. the size changing is minimal. Re: default value test — Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://private-user-images.githubusercontent.com/779050/520013052-2c3adc0d-d8ea-49b2-8627-0c86347defea.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjQ2NjgzODcsIm5iZiI6MTc2NDY2ODA4NywicGF0aCI6Ii83NzkwNTAvNTIwMDEzMDUyLTJjM2FkYzBkLWQ4ZWEtNDliMi04NjI3LTBjODYzNDdkZWZlYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUxMjAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MTIwMlQwOTM0NDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05Y2Q2MzNiMjk2ZjY0MjAwNDM1NmIxMWMwY2ZmOWVhNzg5OGRjZTYzZmEyZDVmMmJhOTc3ODVmNzRhYzZiODg0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.GjmpE-2Qh4jTp0A1_6o2QJJ2kKhgQR7AbUfsqhwnwI4"](https://private-user-images.githubusercontent.com/779050/520013052-2c3adc0d-d8ea-49b2-8627-0c86347defea.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjQ2NjgzODcsIm5iZiI6MTc2NDY2ODA4NywicGF0aCI6Ii83NzkwNTAvNTIwMDEzMDUyLTJjM2FkYzBkLWQ4ZWEtNDliMi04NjI3LTBjODYzNDdkZWZlYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUxMjAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MTIwMlQwOTM0NDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05Y2Q2MzNiMjk2ZjY0MjAwNDM1NmIxMWMwY2ZmOWVhNzg5OGRjZTYzZmEyZDVmMmJhOTc3ODVmNzRhYzZiODg0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.GjmpE-2Qh4jTp0A1_6o2QJJ2kKhgQR7AbUfsqhwnwI4"){kind=link}