natsuokawai commented on code in PR #21390:
URL: https://github.com/apache/echarts/pull/21390#discussion_r2613651436
##########
src/component/matrix/MatrixView.ts:
##########
@@ -359,6 +365,18 @@ function createMatrixCell(
}
cellRect.silent = rectSilent;
+ if (triggerEvent && cellText) {
+ const eventData = {
+ componentType: 'matrix' as const,
+ componentIndex: matrixModel.componentIndex,
+ matrixIndex: matrixModel.componentIndex,
+ targetType: targetType,
+ name: textValue != null ? textValue + '' : null,
+ coord: xyLocator.slice()
+ };
+ getECData(cellText).eventData = eventData;
+ }
Review Comment:
@Ovilia
I figured that cells without text (so, no actual data) probably don't need
to trigger events.
The way I see it, ECharts events are mainly for when you want to do
something with the data shown at a particular point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
