Justin-ZS commented on PR #21618: URL: https://github.com/apache/echarts/pull/21618#issuecomment-4601251931
Runtime change LGTM. Treating pie label.position: 'outside' the same as 'outer' in the labelLine alignment branch matches the existing PieView and label rotation handling. One blocker before merge: the added regression test currently fails locally and should make the build job fail at the Unit Test step. is undefined for pie; is stored on the item layout / sector shape instead. Please use or when classifying left/right labels. I verified the new test fails as-is with: > [email protected] test > npx jest --config test/ut/jest.config.cjs --runInBand test/ut/spec/series/pie.test.ts --coverage=false No tests found, exiting with code 1 Run with `--passWithNoTests` to exit with code 0 In /Users/jinzisen/Work/official/echarts/test/ut 34 files checked. testMatch: **/spec/api/*.test.ts, **/spec/component/**/*.test.ts, **/spec/series/**/*.test.ts, **/spec/data/*.test.ts, **/spec/model/*.test.ts, **/spec/scale/*.test.ts, **/spec/util/*.test.ts - 25 matches testPathIgnorePatterns: /node_modules/ - 34 matches testRegex: - 0 matches Pattern: test/ut/spec/series/pie.test.ts - 0 matches After changing the test to read from , the test passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
