SEPURI-SAI-KRISHNA commented on PR #21735: URL: https://github.com/apache/echarts/pull/21735#issuecomment-5488952038
Noting some prior work I came across: the `removeNodeEdge` guard in this PR overlaps #18491, which fixes the same `Cannot read properties of null (reading '__edge')` crash. That PR goes further, it threads the current/source symbols into `removeNodeEdge` so `sourceSymbolEl` is never null to begin with, and it also fixes polyline edge cleanup when animation is off (#18448, #18490). The other change here is independent of #18491: when `series.data` is emptied, or when no node has a layout yet, `bbox.fromPoints` returns early and leaves `min`/`max` as empty arrays. `max[0] - min[0]` is then `NaN`, which the zero-size checks below don't correct, so the resulting dataRect produces a singular view transform, `matrix.invert` returns `null`, and `legacyCopyOverallTrans` throws. If you'd rather land #18491 for the `removeNodeEdge` part, I'm happy to drop that hunk and scope this PR to the empty-data crash alone. Just let me know which you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
