add logging for some other publish failure conditions Project: http://git-wip-us.apache.org/repos/asf/incubator-edgent/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-edgent/commit/56b9716e Tree: http://git-wip-us.apache.org/repos/asf/incubator-edgent/tree/56b9716e Diff: http://git-wip-us.apache.org/repos/asf/incubator-edgent/diff/56b9716e
Branch: refs/heads/master Commit: 56b9716e50febac9cdf80331f7810b464326ce0e Parents: 983a53b Author: Dale LaBossiere <[email protected]> Authored: Tue Feb 21 08:41:56 2017 -0500 Committer: Dale LaBossiere <[email protected]> Committed: Tue Feb 21 08:41:56 2017 -0500 ---------------------------------------------------------------------- .../edgent/connectors/iotp/runtime/IotpConnector.java | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-edgent/blob/56b9716e/connectors/iotp/src/main/java/org/apache/edgent/connectors/iotp/runtime/IotpConnector.java ---------------------------------------------------------------------- diff --git a/connectors/iotp/src/main/java/org/apache/edgent/connectors/iotp/runtime/IotpConnector.java b/connectors/iotp/src/main/java/org/apache/edgent/connectors/iotp/runtime/IotpConnector.java index 7ece528..6639c40 100644 --- a/connectors/iotp/src/main/java/org/apache/edgent/connectors/iotp/runtime/IotpConnector.java +++ b/connectors/iotp/src/main/java/org/apache/edgent/connectors/iotp/runtime/IotpConnector.java @@ -28,6 +28,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import com.google.gson.JsonObject; +import com.ibm.iotf.client.api.APIClient; import com.ibm.iotf.client.api.APIClient.ContentType; import com.ibm.iotf.client.device.Command; import com.ibm.iotf.client.device.DeviceClient; @@ -102,20 +103,24 @@ public class IotpConnector implements Serializable, AutoCloseable { throw new RuntimeException(e); } - client.publishEvent(eventId, event, qos); + if (!client.publishEvent(eventId, event, qos)) { + logger.error("Publish event failed for eventId {}", eventId); + } } void publishHttpEvent(String eventId, JsonObject event) { try { - DeviceClient client = getClient(); - client.api().publishDeviceEventOverHTTP(eventId, event, ContentType.json); + APIClient api = getClient().api(); + if (!api.publishDeviceEventOverHTTP(eventId, event, ContentType.json)) { + logger.error("HTTP publish event failed for eventId {}", eventId); + } } catch (Exception e) { // throw new RuntimeException(e); // If the publish throws, a RuntimeException will cause // everything to unwind and the app/topology can terminate. // See the commentary/impl of MqttPublisher.accept(). // See EDGENT-382 - logger.error("Unable to publish tuple for event " + eventId, e); + logger.error("Unable to publish event for eventId {}", eventId, e); } }
