This is an automated email from the ASF dual-hosted git repository.
jonyang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-eventmesh.git
The following commit(s) were added to refs/heads/master by this push:
new 92be0fdc1 fix #2360 (#2482)
92be0fdc1 is described below
commit 92be0fdc15d4b7fb3c8c9193699b6307cf94ee79
Author: YuanXin Hu <[email protected]>
AuthorDate: Tue Dec 6 22:07:26 2022 +0800
fix #2360 (#2482)
#2360
---
.../core/protocol/tcp/client/task/MessageTransferTask.java | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
index 74d89b902..a90e81475 100644
---
a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
+++
b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
@@ -172,7 +172,7 @@ public class MessageTransferTask extends AbstractTask {
session.getClient(),
e);
- if (!cmd.equals(RESPONSE_TO_SERVER)) {
+ if (cmd != RESPONSE_TO_SERVER) {
msg.setHeader(
new Header(replyCmd, OPStatus.FAIL.getCode(), e.toString(),
pkg.getHeader()
@@ -187,7 +187,7 @@ public class MessageTransferTask extends AbstractTask {
}
private CloudEvent addTimestamp(CloudEvent event, Command cmd, long
sendTime) {
- if (cmd.equals(RESPONSE_TO_SERVER)) {
+ if (cmd == RESPONSE_TO_SERVER) {
event = CloudEventBuilder.from(event)
.withExtension(EventMeshConstants.RSP_C2EVENTMESH_TIMESTAMP,
String.valueOf(startTime))
@@ -234,8 +234,8 @@ public class MessageTransferTask extends AbstractTask {
messageLogger.info("upstreamMsg message
success|user={}|callback cost={}",
session.getClient(),
System.currentTimeMillis() - createTime);
- if (replyCmd.equals(Command.BROADCAST_MESSAGE_TO_SERVER_ACK)
- || replyCmd.equals(Command.ASYNC_MESSAGE_TO_SERVER_ACK)) {
+ if (replyCmd == Command.BROADCAST_MESSAGE_TO_SERVER_ACK
+ || replyCmd == Command.ASYNC_MESSAGE_TO_SERVER_ACK) {
msg.setHeader(
new Header(replyCmd, OPStatus.SUCCESS.getCode(),
OPStatus.SUCCESS.getDesc(),
pkg.getHeader().getSeq()));
@@ -273,7 +273,7 @@ public class MessageTransferTask extends AbstractTask {
Utils.writeAndFlush(msg, startTime, taskExecuteTime,
session.getContext(), session);
//both rr request and async request need finish span when
reqeust fail
- if (!replyCmd.equals(RESPONSE_TO_SERVER)) {
+ if (replyCmd != RESPONSE_TO_SERVER) {
//upload trace
TraceUtils.finishSpanWithException(ctx, event,
"upload trace fail in
MessageTransferTask.createSendCallback.onException",
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
