This is an automated email from the ASF dual-hosted git repository.
jonyang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-eventmesh.git
The following commit(s) were added to refs/heads/master by this push:
new 8609e04b9 [ISSUE #3166] Discard unnecessary `return` (#3194)
8609e04b9 is described below
commit 8609e04b9e462bb5bb89708b0ee2af5b22a4a06e
Author: dingrui <[email protected]>
AuthorDate: Sun Feb 19 10:39:11 2023 +0800
[ISSUE #3166] Discard unnecessary `return` (#3194)
* [ISSUE #3166] Discard unnecessary `return`
* [ISSUE #3166] `logger` placeholder
---
.../apache/eventmesh/runtime/client/impl/PubClientImpl.java | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git
a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java
b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java
index 4fac9067b..67670a17c 100644
---
a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java
+++
b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java
@@ -89,11 +89,11 @@ public class PubClientImpl extends TCPClient implements
PubClient {
Package msg = MessageUtils.heartBeat();
if (log.isDebugEnabled()) {
log.debug("PubClientImpl|{}|send
heartbeat|Command={}|msg={}",
- clientNo, msg.getHeader().getCommand(), msg);
+ clientNo, msg.getHeader().getCommand(), msg);
}
PubClientImpl.this.dispatcher(msg,
ClientConstants.DEFAULT_TIMEOUT_IN_MILLISECONDS);
- } catch (Exception e) {
- //ignore
+ } catch (Exception ignored) {
+ // ignore
}
}, ClientConstants.HEARTBEAT, ClientConstants.HEARTBEAT,
TimeUnit.MILLISECONDS);
}
@@ -188,6 +188,7 @@ public class PubClientImpl extends TCPClient implements
PubClient {
@ChannelHandler.Sharable
private class Handler extends SimpleChannelInboundHandler<Package> {
+
@Override
protected void channelRead0(ChannelHandlerContext ctx, Package msg)
throws Exception {
if (log.isInfoEnabled()) {
@@ -207,23 +208,19 @@ public class PubClientImpl extends TCPClient implements
PubClient {
if (context != null) {
contexts.remove(context.getKey());
context.finish(msg);
- return;
} else {
log.error("msg ignored,context not found .|{}|{}", cmd,
msg);
- return;
}
} else if (cmd == Command.SERVER_GOODBYE_REQUEST) {
- log.error("server goodby request: ---------------------------"
+ msg);
+ log.error("server goodbye request:
---------------------------{}", msg);
close();
} else {
RequestContext context =
contexts.get(RequestContext.getHeaderSeq(msg));
if (context != null) {
contexts.remove(context.getKey());
context.finish(msg);
- return;
} else {
log.error("msg ignored,context not found .|{}|{}", cmd,
msg);
- return;
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
