This is an automated email from the ASF dual-hosted git repository.
mikexue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/eventmesh.git
The following commit(s) were added to refs/heads/master by this push:
new b669a02ea Optimized BeanUtilsTest.java
new 66ba71358 Merge pull request #3661 from kyooosukedn/patch-6
b669a02ea is described below
commit b669a02ea7d92c533c7496f2e8944f5ef72709a4
Author: kyooosukedn <[email protected]>
AuthorDate: Fri Apr 7 17:08:27 2023 +0200
Optimized BeanUtilsTest.java
---
.../storage/rocketmq/utils/BeanUtilsTest.java | 32 ++++++++++------------
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git
a/eventmesh-storage-plugin/eventmesh-storage-rocketmq/src/test/java/org/apache/eventmesh/storage/rocketmq/utils/BeanUtilsTest.java
b/eventmesh-storage-plugin/eventmesh-storage-rocketmq/src/test/java/org/apache/eventmesh/storage/rocketmq/utils/BeanUtilsTest.java
index a10a9619d..9f62ef2a6 100644
---
a/eventmesh-storage-plugin/eventmesh-storage-rocketmq/src/test/java/org/apache/eventmesh/storage/rocketmq/utils/BeanUtilsTest.java
+++
b/eventmesh-storage-plugin/eventmesh-storage-rocketmq/src/test/java/org/apache/eventmesh/storage/rocketmq/utils/BeanUtilsTest.java
@@ -28,7 +28,7 @@ import org.junit.Test;
public class BeanUtilsTest {
- private Properties properties = new Properties();
+ private final Properties properties = new Properties();
public static class CustomizedConfig extends ClientConfig {
@@ -84,13 +84,12 @@ public class BeanUtilsTest {
public void testPopulate() {
CustomizedConfig config = BeanUtils.populate(properties,
CustomizedConfig.class);
- //RemotingConfig config = BeanUtils.populate(properties,
RemotingConfig.class);
- Assert.assertEquals(config.getRmqMaxRedeliveryTimes(), 120);
- Assert.assertEquals(config.getStringTest(), "kaka");
- Assert.assertEquals(config.getRmqConsumerGroup(),
"Default_Consumer_Group");
- Assert.assertEquals(config.getRmqMessageConsumeTimeout(), 101);
- Assert.assertEquals(config.getLongTest(), 1234567890L);
- Assert.assertEquals(config.getDoubleTest(), 10.234, 0.000001);
+ Assert.assertEquals(120, config.getRmqMaxRedeliveryTimes());
+ Assert.assertEquals("kaka", config.getStringTest());
+ Assert.assertEquals("Default_Consumer_Group",
config.getRmqConsumerGroup());
+ Assert.assertEquals(101, config.getRmqMessageConsumeTimeout());
+ Assert.assertEquals(1234567890L, config.getLongTest());
+ Assert.assertEquals(10.234, 0.000001, config.getDoubleTest());
}
@Test
@@ -98,17 +97,16 @@ public class BeanUtilsTest {
CustomizedConfig config = new CustomizedConfig();
config.setConsumerId("NewConsumerId");
- Assert.assertEquals(config.getConsumerId(), "NewConsumerId");
+ Assert.assertEquals("NewConsumerId", config.getConsumerId());
- config = BeanUtils.populate(properties, config);
+ BeanUtils.populate(properties, config);
- //RemotingConfig config = BeanUtils.populate(properties,
RemotingConfig.class);
- Assert.assertEquals(config.getRmqMaxRedeliveryTimes(), 120);
- Assert.assertEquals(config.getStringTest(), "kaka");
- Assert.assertEquals(config.getRmqConsumerGroup(),
"Default_Consumer_Group");
- Assert.assertEquals(config.getRmqMessageConsumeTimeout(), 101);
- Assert.assertEquals(config.getLongTest(), 1234567890L);
- Assert.assertEquals(config.getDoubleTest(), 10.234, 0.000001);
+ Assert.assertEquals(120, config.getRmqMaxRedeliveryTimes());
+ Assert.assertEquals("kaka", config.getStringTest());
+ Assert.assertEquals("Default_Consumer_Group",
config.getRmqConsumerGroup());
+ Assert.assertEquals(101, config.getRmqMessageConsumeTimeout());
+ Assert.assertEquals(1234567890L, config.getLongTest());
+ Assert.assertEquals(10.234, 0.000001, config.getDoubleTest());
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
