This is an automated email from the ASF dual-hosted git repository.
weihu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/eventmesh.git
The following commit(s) were added to refs/heads/master by this push:
new 1bf3755e2 use a primitive boolean expression in GithubProtocol.java
new 9fe9f18a4 Merge pull request #3755 from Ceilzcx/issues_3720
1bf3755e2 is described below
commit 1bf3755e2accbd65cc17106b35ba2096760e6cd4
Author: ceilzcx <[email protected]>
AuthorDate: Tue Apr 18 10:44:13 2023 +0800
use a primitive boolean expression in GithubProtocol.java
---
.../org/apache/eventmesh/webhook/receive/protocol/GithubProtocol.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/eventmesh-webhook/eventmesh-webhook-receive/src/main/java/org/apache/eventmesh/webhook/receive/protocol/GithubProtocol.java
b/eventmesh-webhook/eventmesh-webhook-receive/src/main/java/org/apache/eventmesh/webhook/receive/protocol/GithubProtocol.java
index e8ed1b79d..63d083920 100644
---
a/eventmesh-webhook/eventmesh-webhook-receive/src/main/java/org/apache/eventmesh/webhook/receive/protocol/GithubProtocol.java
+++
b/eventmesh-webhook/eventmesh-webhook-receive/src/main/java/org/apache/eventmesh/webhook/receive/protocol/GithubProtocol.java
@@ -56,7 +56,7 @@ public class GithubProtocol implements ManufacturerProtocol {
final Map<String, String> header) throws Exception {
final String fromSignature = header.get(FROM_SIGNATURE);
- if (!isValid(fromSignature, webHookRequest.getData(),
webHookConfig.getSecret())) {
+ if (Boolean.FALSE.equals(isValid(fromSignature,
webHookRequest.getData(), webHookConfig.getSecret()))) {
throw new Exception("webhook-GithubProtocol authenticate failed");
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
