This is an automated email from the ASF dual-hosted git repository.
mikexue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/eventmesh.git
The following commit(s) were added to refs/heads/master by this push:
new dc7903697 [ISSUE #4038]Optimize eventmesh-openconnect log print (#4039)
dc7903697 is described below
commit dc7903697313d107b1947ef204be939763e3b855
Author: mxsm <[email protected]>
AuthorDate: Tue May 30 16:01:31 2023 +0800
[ISSUE #4038]Optimize eventmesh-openconnect log print (#4039)
---
.../src/main/java/org/apache/eventmesh/openconnect/SinkWorker.java | 7 +++----
.../main/java/org/apache/eventmesh/openconnect/SourceWorker.java | 5 ++---
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git
a/eventmesh-openconnect/eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SinkWorker.java
b/eventmesh-openconnect/eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SinkWorker.java
index b23b402c8..6cdaa629a 100644
---
a/eventmesh-openconnect/eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SinkWorker.java
+++
b/eventmesh-openconnect/eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SinkWorker.java
@@ -89,8 +89,8 @@ public class SinkWorker implements ConnectorWorker {
try {
sink.start();
} catch (Exception e) {
- e.printStackTrace();
- log.error(e.getMessage());
+ log.error("sink worker[{}] start fail", sink.name(), e);
+ return;
}
eventMeshTCPClient.subscribe(config.getPubSubConfig().getSubject(),
SubscriptionMode.CLUSTERING,
SubscriptionType.ASYNC);
@@ -105,7 +105,6 @@ public class SinkWorker implements ConnectorWorker {
eventMeshTCPClient.unsubscribe();
eventMeshTCPClient.close();
} catch (Exception e) {
- e.printStackTrace();
log.error("event mesh client close", e);
}
try {
@@ -113,11 +112,11 @@ public class SinkWorker implements ConnectorWorker {
} catch (Exception e) {
log.error("sink destroy error", e);
}
-
log.info("source worker stopped");
}
static class EventHandler implements ReceiveMsgHook<CloudEvent> {
+
private final Sink sink;
public EventHandler(Sink sink) {
diff --git
a/eventmesh-openconnect/eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java
b/eventmesh-openconnect/eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java
index e4baff9ba..b479aa982 100644
---
a/eventmesh-openconnect/eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java
+++
b/eventmesh-openconnect/eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java
@@ -101,11 +101,10 @@ public class SourceWorker implements ConnectorWorker {
eventMeshTCPClient.publish(event, 3000);
}
}
+ log.info("source worker[{}] started", source.name());
} catch (Exception e) {
- e.printStackTrace();
- log.error(e.getMessage());
+ log.error("source worker[{}] start fail", source.name(), e);
}
- log.info("source worker started");
}
private CloudEvent convertRecordToEvent(ConnectRecord connectRecord) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
