This is an automated email from the ASF dual-hosted git repository. chenguangsheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/eventmesh-go.git
commit 1871a33d8ea396b24936692914a58d22d7654fe7 Author: Harshitha Sudhakar <[email protected]> AuthorDate: Wed Apr 26 17:04:15 2023 +0530 Update writer_factory.go Some code optimization at lines 49,80,88. --- log/writer_factory.go | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/log/writer_factory.go b/log/writer_factory.go index b2bd073..9e16bd2 100644 --- a/log/writer_factory.go +++ b/log/writer_factory.go @@ -46,7 +46,7 @@ type ConsoleWriterFactory struct { } // Setup starts, loads and registers console output writer. -func (f *ConsoleWriterFactory) Setup(name string, dec plugin.Decoder) error { +func (f *ConsoleWriterFactory) Setup(_ string, dec plugin.Decoder) error { if dec == nil { return errors.New("console writer decoder empty") } @@ -77,7 +77,7 @@ func (f *ConsoleWriterFactory) Type() string { } // Setup starts, loads and register file output writer. -func (f *FileWriterFactory) Setup(name string, dec plugin.Decoder) error { +func (f *FileWriterFactory) Setup(_ string, dec plugin.Decoder) error { if dec == nil { return errors.New("file writer decoder empty") } @@ -85,10 +85,7 @@ func (f *FileWriterFactory) Setup(name string, dec plugin.Decoder) error { if !ok { return errors.New("file writer log decoder type invalid") } - if err := f.setupConfig(decoder); err != nil { - return err - } - return nil + return f.setupConfig(decoder) } func (f *FileWriterFactory) setupConfig(decoder *Decoder) error { --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
