This is an automated email from the ASF dual-hosted git repository.

mikexue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/eventmesh.git


The following commit(s) were added to refs/heads/master by this push:
     new 8ad08ba1e [ISSUE #4194]Dereference of 'heartbeatItems' may produce 
NPE. (#4235)
8ad08ba1e is described below

commit 8ad08ba1e8d7b773d77b27f83a9ea4cbabb920bb
Author: codingprh <[email protected]>
AuthorDate: Thu Jul 20 10:28:06 2023 +0800

    [ISSUE #4194]Dereference of 'heartbeatItems' may produce NPE. (#4235)
    
    * fix: Dereference of 'heartbeatItems' may produce NPE.
    
    * style: code checkstyle.
    
    ---------
    
    Co-authored-by: noah.pan <[email protected]>
---
 .../runtime/core/protocol/grpc/processor/HeartbeatProcessor.java        | 2 ++
 1 file changed, 2 insertions(+)

diff --git 
a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/processor/HeartbeatProcessor.java
 
b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/processor/HeartbeatProcessor.java
index 805f16f35..b661fc673 100644
--- 
a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/processor/HeartbeatProcessor.java
+++ 
b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/processor/HeartbeatProcessor.java
@@ -34,6 +34,7 @@ import 
org.apache.eventmesh.runtime.core.protocol.grpc.service.ServiceUtils;
 
 import java.util.Date;
 import java.util.List;
+import java.util.Objects;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -92,6 +93,7 @@ public class HeartbeatProcessor {
         List<HeartbeatItem> heartbeatItems = 
JsonUtils.parseTypeReferenceObject(heartbeat.getTextData(),
             new TypeReference<List<HeartbeatItem>>() {
             });
+        Objects.requireNonNull(heartbeatItems, "heartbeatItems can't be null");
         for (HeartbeatItem item : heartbeatItems) {
             ConsumerGroupClient hbClient = ConsumerGroupClient.builder()
                 .env(env)


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to