This is an automated email from the ASF dual-hosted git repository.
mikexue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/eventmesh.git
The following commit(s) were added to refs/heads/master by this push:
new fef56a5ad [ISSUE #4260] Anonymous new ChannelFutureListener() can be
replaced with lambda[HelloTask] (#4316)
fef56a5ad is described below
commit fef56a5ad07c22560df01877ffd6af852d65a942
Author: Shubam Virdi <[email protected]>
AuthorDate: Wed Aug 2 20:06:47 2023 +0530
[ISSUE #4260] Anonymous new ChannelFutureListener() can be replaced with
lambda[HelloTask] (#4316)
* [4260] Fixed: Anonymous new ChannelFutureListener() can be replaced with
lambda[HelloTask]
* Upgraded: First Interaction Action Version to Latest
* [4260] Removed: Unused Import
* Update package import order in HelloTask.java
---------
Co-authored-by: mike_xwm <[email protected]>
---
.github/workflows/greetings.yml | 2 +-
.../eventmesh/runtime/core/protocol/tcp/client/task/HelloTask.java | 7 +------
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/.github/workflows/greetings.yml b/.github/workflows/greetings.yml
index 6d866559e..cc4cff977 100644
--- a/.github/workflows/greetings.yml
+++ b/.github/workflows/greetings.yml
@@ -26,7 +26,7 @@ jobs:
name: Greeting
runs-on: ubuntu-latest
steps:
- - uses: actions/first-interaction@v1
+ - uses: actions/[email protected]
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
issue-message: |
diff --git
a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/HelloTask.java
b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/HelloTask.java
index e024143cc..47b54508d 100644
---
a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/HelloTask.java
+++
b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/HelloTask.java
@@ -40,11 +40,9 @@ import java.util.Arrays;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import io.netty.channel.ChannelFuture;
import io.netty.channel.ChannelFutureListener;
import io.netty.channel.ChannelHandlerContext;
-
import lombok.extern.slf4j.Slf4j;
@Slf4j
@@ -96,9 +94,7 @@ public class HelloTask extends AbstractTask {
res.setHeader(new Header(HELLO_RESPONSE, OPStatus.FAIL.getCode(),
Arrays.toString(e.getStackTrace()), pkg
.getHeader().getSeq()));
ctx.writeAndFlush(res).addListener(
- new ChannelFutureListener() {
- @Override
- public void operationComplete(ChannelFuture future) throws
Exception {
+ (ChannelFutureListener) future -> {
if (!future.isSuccess()) {
Utils.logFailedMessageFlow(future, res, user,
startTime, taskExecuteTime);
} else {
@@ -107,7 +103,6 @@ public class HelloTask extends AbstractTask {
log.warn("HelloTask failed,close session,addr:{}",
ctx.channel().remoteAddress());
eventMeshTCPServer.getClientSessionGroupMapping().closeSession(ctx);
}
- }
);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
