FALCON-1413 Filter By throws wrong error in case of wrong argument being passed. Contributed by Narayan Periwal.
Project: http://git-wip-us.apache.org/repos/asf/falcon/repo Commit: http://git-wip-us.apache.org/repos/asf/falcon/commit/5ae9f314 Tree: http://git-wip-us.apache.org/repos/asf/falcon/tree/5ae9f314 Diff: http://git-wip-us.apache.org/repos/asf/falcon/diff/5ae9f314 Branch: refs/heads/master Commit: 5ae9f314e344d1a31a76fd694f5336f93d63036a Parents: f0cdb34 Author: Ajay Yadava <[email protected]> Authored: Fri Sep 4 15:23:19 2015 +0530 Committer: Ajay Yadava <[email protected]> Committed: Fri Sep 4 15:23:19 2015 +0530 ---------------------------------------------------------------------- CHANGES.txt | 2 ++ client/src/main/java/org/apache/falcon/cli/FalconCLI.java | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/falcon/blob/5ae9f314/CHANGES.txt ---------------------------------------------------------------------- diff --git a/CHANGES.txt b/CHANGES.txt index c5b775d..ea11c64 100755 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -12,6 +12,8 @@ Trunk (Unreleased) OPTIMIZATIONS BUG FIXES + FALCON-1413 Filter By throws wrong error in case of wrong argument being passed(Narayan Periwal via Ajay Yadava) + FALCON-1421 checkColos should be a no-op for embedded mode(Venkat Ranganathan via Ajay Yadava) http://git-wip-us.apache.org/repos/asf/falcon/blob/5ae9f314/client/src/main/java/org/apache/falcon/cli/FalconCLI.java ---------------------------------------------------------------------- diff --git a/client/src/main/java/org/apache/falcon/cli/FalconCLI.java b/client/src/main/java/org/apache/falcon/cli/FalconCLI.java index 11dfe72..d4da302 100644 --- a/client/src/main/java/org/apache/falcon/cli/FalconCLI.java +++ b/client/src/main/java/org/apache/falcon/cli/FalconCLI.java @@ -604,10 +604,10 @@ public class FalconCLI { }else if (filterType.equals("summary")) { InstancesSummaryResult.InstanceSummaryFilterFields.valueOf(tempKeyVal[0].toUpperCase()); } else { - throw new IllegalArgumentException("Invalid API call"); + throw new IllegalArgumentException("Invalid API call: filterType is not valid"); } } catch (IllegalArgumentException ie) { - throw new FalconCLIException("Invalid filterBy argument : " + FILTER_BY_OPT); + throw new FalconCLIException("Invalid filterBy argument : " + tempKeyVal[0] + " in : " + s); } } }
