(felix-dev) 18/19: [fw] use StringBuilder for String concatenation

[stbischof]

This is an automated email from the ASF dual-hosted git repository.

stbischof pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/felix-dev.git

commit 14e9e75a6ad58ed9221f6cd7f2c45da5ebe2dc5c
Author: Stefan Bischof <stbisc...@bipolis.org>
AuthorDate: Sat Apr 5 10:18:17 2025 +0200

    [fw] use StringBuilder for String concatenation
    
    Signed-off-by: Stefan Bischof <stbisc...@bipolis.org>
---
 .../java/org/apache/felix/framework/ExtensionManager.java  | 14 +++++++-------
 .../apache/felix/framework/ServiceRegistrationImpl.java    | 10 +++++-----
 .../main/java/org/apache/felix/framework/util/Util.java    |  6 +++---
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git 
a/framework/src/main/java/org/apache/felix/framework/ExtensionManager.java 
b/framework/src/main/java/org/apache/felix/framework/ExtensionManager.java
index 796802d8bd..982e16e458 100644
--- a/framework/src/main/java/org/apache/felix/framework/ExtensionManager.java
+++ b/framework/src/main/java/org/apache/felix/framework/ExtensionManager.java
@@ -322,26 +322,26 @@ class ExtensionManager implements Content
                         }
                     }
 
-                    String pkgs = "";
+                    StringBuilder pkgs = new StringBuilder();
 
                     for (String pkg : exports.get(moduleKey))
                     {
-                        pkgs += "," + pkg;
+                        pkgs.append(",").append(pkg);
                         SortedSet<String> uses = referred.get(pkg);
                         if (uses != null && !uses.isEmpty())
                         {
-                            pkgs += ";uses:=\"";
+                            pkgs.append(";uses:=\"");
                             String sep = "";
                             for (String u : uses)
                             {
-                                pkgs += sep + u;
+                                pkgs.append(sep).append(u);
                                 sep = ",";
                             }
-                            pkgs += "\"";
+                            pkgs.append("\"");
                         }
-                        pkgs += ";version=\"" + 
defaultProperties.getProperty("felix.detect.java.version") + "\"";
+                        
pkgs.append(";version=\"").append(defaultProperties.getProperty("felix.detect.java.version")).append("\"");
                     }
-                    defaultProperties.put(module, pkgs);
+                    defaultProperties.put(module, pkgs.toString());
                 }
             }
         }
diff --git 
a/framework/src/main/java/org/apache/felix/framework/ServiceRegistrationImpl.java
 
b/framework/src/main/java/org/apache/felix/framework/ServiceRegistrationImpl.java
index 6dff959f19..ed4b8e5b9b 100644
--- 
a/framework/src/main/java/org/apache/felix/framework/ServiceRegistrationImpl.java
+++ 
b/framework/src/main/java/org/apache/felix/framework/ServiceRegistrationImpl.java
@@ -513,15 +513,15 @@ class ServiceRegistrationImpl implements 
ServiceRegistration
         public String toString()
         {
             String[] ocs = (String[]) getProperty("objectClass");
-            String oc = "[";
+            StringBuilder oc = new StringBuilder("[");
             for(int i = 0; i < ocs.length; i++)
             {
-                oc = oc + ocs[i];
+                oc.append(ocs[i]);
                 if (i < ocs.length - 1)
-                    oc = oc + ", ";
+                    oc.append(", ");
             }
-            oc = oc + "]";
-            return oc;
+            oc.append("]");
+            return oc.toString();
         }
 
         @Override
diff --git a/framework/src/main/java/org/apache/felix/framework/util/Util.java 
b/framework/src/main/java/org/apache/felix/framework/util/Util.java
index f0839c9288..ef00a58f46 100644
--- a/framework/src/main/java/org/apache/felix/framework/util/Util.java
+++ b/framework/src/main/java/org/apache/felix/framework/util/Util.java
@@ -253,11 +253,11 @@ public class Util
                 }
             }
 
-            String modulesString = "";
+            StringBuilder modulesString = new StringBuilder();
             for (String module : modules) {
-                modulesString += "${" + module + "}";
+                modulesString.append("${").append(module).append("}");
             }
-            properties.put("jre-jpms", modulesString);
+            properties.put("jre-jpms", modulesString.toString());
         }
 
         return exports;