delei commented on PR #647: URL: https://github.com/apache/fesod/pull/647#issuecomment-3410670254
Hi, @GGBOUNDBOY Thank you for submitting this PR. FYI, we do need to support internationalization. I feel the current implementation proposal seems overly simplified. We need to discuss solutions in issue #57 , such as supporting `Locale` and `MessageSource`. Without further improvements or optimized implementation solutions, it is recommended not to merge this PR yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
