psxjoy commented on PR #653: URL: https://github.com/apache/fesod/pull/653#issuecomment-3424984919
Let me be more explicit: I won't merge this PR at this time. 1. The issue hasn't been claimed; 2. The proposed changes weren't discussed beforehand; 3. Basic formatting wasn't done according to the contribution guidelines (though this isn't critical—we can assist with that); 4. Last but not least: none of the test cases passed. We welcome all contributors, but submitting large amounts of code without prior discussion makes code review extremely difficult. 我更直白的表达一下：我目前不会合并改PR。 1. 没有在issue 认领; 2. 修改的方案并没有进行简单的前期沟通； 3. 没有按照贡献指南进行简单的处理（当然这个不重要，我们可以协助修改） 4. 最后：所有的测试用例都没有通过。 我们欢迎所有的贡献者，但是没有经过前期沟通，提交太多的代码会让code-review 变得困难。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
