bengbengbalabalabeng commented on PR #668: URL: https://github.com/apache/fesod/pull/668#issuecomment-3477737103
> Concern on the eager to new, any potential performance impact here? > > And meanwhile, `head.stream().map(ArrayList::new).collect(Collectors.toList())` is not the deep copy. I considered another approach in #665: In `cn.idev.excel.metadata.property.ExcelHeadProperty#ExcelHeadProperty` constructor. - Wrap `head.get(i)` with `ArrayList<String>`. - But since the constructor may run multiple times during debugging, this could lead to repeated wrapping. So I decided not to adopt that solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
