ongdisheng commented on PR #667:
URL: https://github.com/apache/fesod/pull/667#issuecomment-3513160346

   Hi @alaahong, thank you for pointing me to the Selenium repository. I 
checked their setup and found that they use a different approach from Fesod. 
Selenium has a `netlify.toml` file but doesn't use GitHub Actions for Netlify 
deployment. Instead, they connect their repository directly through Netlify's 
dashboard, which means Netlify builds and deploys automatically on their 
servers without needing tokens in GitHub secrets.
   
   **Fesod's approach**: We currently use the 
[nwtgck/actions-netlify](https://github.com/nwtgck/actions-netlify), which 
builds in GitHub Actions and then deploys to Netlify via their API. This 
requires `NETLIFY_AUTH_TOKEN` and `NETLIFY_SITE_ID` for API authentication 
because the action needs to authenticate with Netlify's API to create deploy 
previews.
   
   **APISIX's approach**: I also found that Apache [APISIX 
](https://github.com/apache/apisix-website) uses the same approach as Fesod 
with GitHub Actions. It seems like they successfully requested the Netlify 
secrets from Apache Infra through JIRA ticket 
[INFRA-23242](https://issues.apache.org/jira/browse/INFRA-23242), and their 
deploy previews are working well as shown in this PR: 
https://github.com/apache/apisix-website/pull/1081
   
   Given that APISIX successfully uses the same approach, would it be possible 
to request the Netlify secrets from Apache Infra similar to their setup? I 
understand that even Selenium's dashboard approach would still require Apache 
Infra involvement to configure the Netlify integration. I'm happy to assist 
with either solution or provide any additional information that might be 
helpful. Thank you for looking into this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to