delei commented on code in PR #682:
URL: https://github.com/apache/fesod/pull/682#discussion_r2513011059
##########
fesod/src/main/java/org/apache/fesod/sheet/FastExcelFactory.java:
##########
@@ -17,21 +17,22 @@
* under the License.
*/
-package org.apache.fesod.excel;
+package org.apache.fesod.sheet;
import java.io.File;
import java.io.InputStream;
import java.io.OutputStream;
-import org.apache.fesod.excel.read.builder.ExcelReaderBuilder;
-import org.apache.fesod.excel.read.builder.ExcelReaderSheetBuilder;
-import org.apache.fesod.excel.read.listener.ReadListener;
-import org.apache.fesod.excel.write.builder.ExcelWriterBuilder;
-import org.apache.fesod.excel.write.builder.ExcelWriterSheetBuilder;
-import org.apache.fesod.excel.write.builder.ExcelWriterTableBuilder;
+import org.apache.fesod.sheet.read.builder.ExcelReaderBuilder;
+import org.apache.fesod.sheet.read.builder.ExcelReaderSheetBuilder;
+import org.apache.fesod.sheet.read.listener.ReadListener;
+import org.apache.fesod.sheet.write.builder.ExcelWriterBuilder;
+import org.apache.fesod.sheet.write.builder.ExcelWriterSheetBuilder;
+import org.apache.fesod.sheet.write.builder.ExcelWriterTableBuilder;
/**
* Reader and writer factory class
*/
+@Deprecated
public class FastExcelFactory {
Review Comment:
These two classes are the same. Avoid maintaining two classes simultaneously
until they are removed in a future release.
How abount this? Clear `FastExcelFactory` class.
```suggestion
public class FastExcelFactory extends FastSheetFactory{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
