ongdisheng commented on code in PR #693:
URL: https://github.com/apache/fesod/pull/693#discussion_r2534909765
##########
fesod/src/main/java/org/apache/fesod/sheet/read/metadata/holder/xlsx/XlsxReadSheetHolder.java:
##########
@@ -54,6 +56,18 @@ public class XlsxReadSheetHolder extends ReadSheetHolder {
* Formula for current label.
*/
private StringBuilder tempFormula;
+ /**
+ * Formula type for current label.
+ */
+ private String tempFormulaType;
+ /**
+ * Formula shared index for current label.
+ */
+ private Integer tempFormulaSharedIndex;
+ /**
+ * Map to store master shared formulas by their shared index.
+ */
+ private Map<Integer, SharedFormulaInfo> sharedFormulaMap;
Review Comment:
Thanks for the suggestion! However, this class uses `@Getter` at the class
level, which already exposes all mutable fields directly including
`Deque<String> tagDeque`. `XlsxReadSheetHolder` is an internal holder class
designed to store temporary parsing state where direct map access is consistent
with how other mutable fields in this class are used. The map is only accessed
by `CellFormulaTagHandler` during the parsing process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
