ongdisheng commented on PR #691: URL: https://github.com/apache/fesod/pull/691#issuecomment-3547801533
Hi @delei, great work on the rename! I noticed a couple of small issues in the website that were missed. 1. `Fesod.read` in [website/docs/introduce.md:57](https://github.com/apache/fesod/blob/efe89d7026f190c2a5b393ad8efb4eb983dd7b88/website/docs/introduce.md?plain=1#L57) where the read example still uses `Fesod.read` instead of `FesodSheet.read`. The Chinese version already has this correct, but the English version was missed. <img width="928" height="468" alt="image" src="https://github.com/user-attachments/assets/d0c2595b-d7c9-4f52-8aab-d02637772943"; /> 2. A few spots in the homepage translations still use `Excel` terminology instead of `spreadsheet` in [website/i18n/en/code.json](https://github.com/apache/fesod/blob/efe89d7026f190c2a5b393ad8efb4eb983dd7b88/website/i18n/en/code.json#L3) such as "reading and writing Excel files" and "large-scale Excel data". <img width="1210" height="610" alt="image" src="https://github.com/user-attachments/assets/e9446ffc-5dd9-4f8c-bcdc-eb9944c2f46b"; /> Just wanted to flag these in case they were overlooked. If you'd like, I'm happy to submit a follow-up PR to fix them! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
